Remove reflectedType hack from Polymer.

Remove reflectedType hack from Polymer.

R=ahe@google.com, jmesserly@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31235

[rmacnak, 2013-12-07 02:32:17]

Depends on https://chromiumcodereview.appspot.com/103713006/

[rmacnak, 2013-12-07 02:34:09]

https://codereview.chromium.org/108523003/diff/1/pkg/polymer/lib/src/loader.dart
File pkg/polymer/lib/src/loader.dart (right):

https://codereview.chromium.org/108523003/diff/1/pkg/polymer/lib/src/loader.d...
pkg/polymer/lib/src/loader.dart:183: Polymer.register(meta.tagName,
c.reflectedType);
Woe to the fool that puts @CustomTag on a generic class...

[ahe, 2013-12-09 13:04:56]

LGTM

[Jennifer Messerly, 2013-12-09 19:00:50]

LGTM!!! horribleHack--. Yay.

https://codereview.chromium.org/108523003/diff/1/pkg/polymer/lib/src/loader.dart
File pkg/polymer/lib/src/loader.dart (right):

https://codereview.chromium.org/108523003/diff/1/pkg/polymer/lib/src/loader.d...
pkg/polymer/lib/src/loader.dart:183: Polymer.register(meta.tagName,
c.reflectedType);
On 2013/12/07 02:34:10, Ryan Macnak wrote:
> Woe to the fool that puts @CustomTag on a generic class...

haha :). yeah, no worries. They could always call Polymer.register manually if
they want that.

[Jennifer Messerly, 2013-12-09 22:58:51]

Just thought of something, do we know what SDK version has a working
reflectedType?

if it's > 1.0 of the Dart SDK we should update the polymer/pubspec.yaml

[rmacnak, 2013-12-10 19:42:05]

On 2013/12/09 22:58:51, John Messerly wrote:
> Just thought of something, do we know what SDK version has a working
> reflectedType?
> 
> if it's > 1.0 of the Dart SDK we should update the polymer/pubspec.yaml

In dart2js, it's under review.  (See first message on this CL.)

[rmacnak, 2013-12-17 21:46:18]

On 2013/12/10 19:42:05, Ryan Macnak wrote:
> On 2013/12/09 22:58:51, John Messerly wrote:
> > Just thought of something, do we know what SDK version has a working
> > reflectedType?
> > 
> > if it's > 1.0 of the Dart SDK we should update the polymer/pubspec.yaml
> 
> In dart2js, it's under review.  (See first message on this CL.)

The implementation in dart2js is committed now.  How do I find what new version
I should use in polymer's pubspec?

[Jennifer Messerly, 2013-12-17 21:51:04]

good question! Maybe Siggi or Nathan can help. Do we know the SVN revision of
the dart2js change?

[rmacnak, 2013-12-17 21:54:37]

On 2013/12/17 21:51:04, John Messerly wrote:
> good question! Maybe Siggi or Nathan can help. Do we know the SVN revision of
> the dart2js change?

r31200

[Jennifer Messerly, 2013-12-18 04:55:12]

lgtm

[rmacnak, 2013-12-18 18:20:00]

Committed patchset #2 manually as r31235 (presubmit successful).