Adds missing calls to reset long_jump_base.

Adds missing calls to reset long_jump_base.

Fixes Issue 15744.

R=hausner@google.com, iposva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31431

[hausner, 2014-01-02 18:54:22]

lgtm with comment

https://codereview.chromium.org/108513016/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/108513016/diff/1/runtime/vm/parser.cc#newcode747
runtime/vm/parser.cc:747: return (*metadata).raw();  // Error evaluating the
metadata.
Not your code, but (*p).xxx is normally written as p->xxx. Feel free to leave as
is.

https://codereview.chromium.org/108513016/diff/1/runtime/vm/parser.cc#newcode868
runtime/vm/parser.cc:868: isolate->set_long_jump_base(base);
I think this should happen after the call to EvaluateMetadata(), so we catch
exceptions in that function. This way we'd never get into the false branch of
this if statement.

[Ivan Posva, 2014-01-02 19:06:07]

LGTM. Thanks for finding these.

After committing this we need to evaluate making the LongJump destructor
maintain the proper scoping of the long_jump_base.

-Ivan

[zra, 2014-01-02 19:14:02]

https://codereview.chromium.org/108513016/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/108513016/diff/1/runtime/vm/parser.cc#newcode747
runtime/vm/parser.cc:747: return (*metadata).raw();  // Error evaluating the
metadata.
On 2014/01/02 18:54:23, hausner wrote:
> Not your code, but (*p).xxx is normally written as p->xxx. Feel free to leave
as
> is.

Done.

https://codereview.chromium.org/108513016/diff/1/runtime/vm/parser.cc#newcode868
runtime/vm/parser.cc:868: isolate->set_long_jump_base(base);
On 2014/01/02 18:54:23, hausner wrote:
> I think this should happen after the call to EvaluateMetadata(), so we catch
> exceptions in that function. This way we'd never get into the false branch of
> this if statement.

Done.

[zra, 2014-01-02 20:53:58]

Committed patchset #2 manually as r31431 (presubmit successful).