Issue 108513013: Add a setter for timeout on Configuration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 108513013: Add a setter for timeout on Configuration (Closed)

Created:
7 years ago by Alan Knight

Modified:
7 years ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add a setter for timeout on Configuration BUG= R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=31094

Patch Set 2 : Make timeout actually a variable on the superclass #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -5 lines)			Patch
	M	pkg/unittest/lib/src/configuration.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	pkg/unittest/lib/src/simple_configuration.dart	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

https://codereview.chromium.org/108513013/diff/1/pkg/unittest/lib/src/configuration.dart File pkg/unittest/lib/src/configuration.dart (right): https://codereview.chromium.org/108513013/diff/1/pkg/unittest/lib/src/configuration.dart#newcode34 pkg/unittest/lib/src/configuration.dart:34: void set timeout(Duration newTimeout) {} Ditch the void. Also, ...

7 years ago (2013-12-11 21:54:19 UTC) #2

Alan Knight

Yeah, it seems silly to have it not just be a variable on the superclass. ...

7 years ago (2013-12-11 23:24:48 UTC) #3

Alan Knight

7 years ago (2013-12-12 00:24:49 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r31094 (presubmit successful).

Expand Messages | Collapse Messages

Issue 108513013: Add a setter for timeout on Configuration (Closed)

Description

Patch Set 1 #

Patch Set 2 : Make timeout actually a variable on the superclass #

Messages