Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1085103002: add the api_readme file to the sdk build (Closed)

Created:
5 years, 8 months ago by keertip
Modified:
5 years, 8 months ago
Reviewers:
ricow1, sethladd
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

add the api_readme file to the sdk build Committed: https://code.google.com/p/dart/source/detail?r=45294

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/create_sdk.py View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (1 generated)
keertip
This helps in generating docs for the sdk.
5 years, 8 months ago (2015-04-15 00:27:51 UTC) #2
ricow1
I don't understand why we need to copy this to the sdk that we ship, ...
5 years, 8 months ago (2015-04-15 06:53:03 UTC) #3
sethladd
We want to support developers generating their own docs, without first getting the entire source ...
5 years, 8 months ago (2015-04-15 15:20:16 UTC) #4
sethladd
Friendly ping. Thanks for taking a look!
5 years, 8 months ago (2015-04-17 00:26:48 UTC) #5
ricow1
Any reason to put this into the top level directory?
5 years, 8 months ago (2015-04-17 10:05:42 UTC) #6
sethladd
I'm agnostic to where it lives. It might make more sense to put it under ...
5 years, 8 months ago (2015-04-17 14:55:40 UTC) #7
keertip
On 2015/04/17 14:55:40, sethladd wrote: > I'm agnostic to where it lives. It might make ...
5 years, 8 months ago (2015-04-17 15:12:53 UTC) #8
sethladd
lib/ is where the API comes from. that's my current vote :)
5 years, 8 months ago (2015-04-17 15:15:33 UTC) #9
keertip
PTAL, readme is now in lib/
5 years, 8 months ago (2015-04-17 16:19:10 UTC) #10
keertip
5 years, 8 months ago (2015-04-20 19:28:44 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r45294 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698