Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1084793006: Add file missed in previous CL and comment clean-up (Closed)

Created:
5 years, 8 months ago by Brian Wilkerson
Modified:
5 years, 8 months ago
Reviewers:
scheglov, danrubel
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add file missed in previous CL and comment clean-up R=danrubel@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=45355

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -23 lines) Patch
M pkg/analysis_server/lib/completion/completion_core.dart View 6 chunks +29 lines, -15 lines 0 comments Download
M pkg/analysis_server/lib/completion/completion_dart.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/edit/assist/assist_core.dart View 3 chunks +6 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/edit/assist/assist_dart.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/edit/fix/fix_core.dart View 3 chunks +6 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/edit/fix/fix_dart.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A + pkg/analysis_server/lib/plugin/completion.dart View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
5 years, 8 months ago (2015-04-22 19:12:23 UTC) #2
scheglov
LGTM
5 years, 8 months ago (2015-04-22 19:15:19 UTC) #3
danrubel
lgtm
5 years, 8 months ago (2015-04-22 19:21:21 UTC) #4
Brian Wilkerson
5 years, 8 months ago (2015-04-22 19:23:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45355 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698