Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1084573006: Refactor SourceMapBuilder to allow for post-processing. (Closed)

Created:
5 years, 8 months ago by Johnni Winther
Modified:
5 years, 8 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Refactor SourceMapBuilder to allow for post-processing. BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=45339

Patch Set 1 #

Patch Set 2 : Update comments. #

Total comments: 2

Patch Set 3 : Updated cf. comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -149 lines) Patch
M pkg/compiler/lib/src/io/source_map_builder.dart View 1 2 5 chunks +216 lines, -147 lines 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 3 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
5 years, 8 months ago (2015-04-22 07:50:42 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/1084573006/diff/20001/pkg/compiler/lib/src/io/source_map_builder.dart File pkg/compiler/lib/src/io/source_map_builder.dart (right): https://codereview.chromium.org/1084573006/diff/20001/pkg/compiler/lib/src/io/source_map_builder.dart#newcode220 pkg/compiler/lib/src/io/source_map_builder.dart:220: Map<int, Map<int, List<T>>> map = <int, Map<int, List<T>>>{}; ...
5 years, 8 months ago (2015-04-22 09:38:22 UTC) #3
Johnni Winther
https://codereview.chromium.org/1084573006/diff/20001/pkg/compiler/lib/src/io/source_map_builder.dart File pkg/compiler/lib/src/io/source_map_builder.dart (right): https://codereview.chromium.org/1084573006/diff/20001/pkg/compiler/lib/src/io/source_map_builder.dart#newcode220 pkg/compiler/lib/src/io/source_map_builder.dart:220: Map<int, Map<int, List<T>>> map = <int, Map<int, List<T>>>{}; On ...
5 years, 8 months ago (2015-04-22 11:04:08 UTC) #4
Johnni Winther
5 years, 8 months ago (2015-04-22 11:24:03 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 45339 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698