Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1084473004: Change isolate done-handler registry back to list instead of HashMap. (Closed)

Created:
5 years, 8 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 8 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, sra1
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Change isolate done-handler registry back to list instead of HashMap. Requires linear search for each operation, but doesn't include HashMap unnecessarily. Reduces size of swarm by 5.9k. R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=45156

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -6 lines) Patch
M sdk/lib/_internal/compiler/js_lib/isolate_helper.dart View 3 chunks +21 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lasse Reichstein Nielsen
5 years, 8 months ago (2015-04-15 09:08:33 UTC) #2
Søren Gjesse
lgtm
5 years, 8 months ago (2015-04-15 09:10:56 UTC) #3
Lasse Reichstein Nielsen
5 years, 8 months ago (2015-04-15 09:30:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45156 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698