Issue 1084153002: Make continuations last in CPS IR constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1084153002: Make continuations last in CPS IR constructors. (Closed)

Created:
5 years, 8 months ago by Kevin Millikin (Google)

Modified:
5 years, 8 months ago

Reviewers:
asgerf, karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

Make continuations last in CPS IR constructors. Continuations are last in both printed representations, but first in the IR constructors. For uniformity, make them last in the IR constructors as well. This is a cosmetic refactoring. BUG= R=asgerf@google.com, karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=45155

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -55 lines)			Patch
M	pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart	View	10 chunks	+14 lines, -14 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart	View	7 chunks	+22 lines, -23 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/codegen/unsugar.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart	View	9 chunks	+6 lines, -16 lines	0 comments	Download

Total messages: 5 (1 generated)

Kevin Millikin (Google)

5 years, 8 months ago (2015-04-15 09:21:26 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 45155 (presubmit successful).