Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 1083663005: Implement try/catch in the JS backend. (Closed)

Created:
5 years, 8 months ago by Kevin Millikin (Google)
Modified:
5 years, 8 months ago
Reviewers:
asgerf, karlklose, sra1
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Implement try/catch in the JS backend. In the CPS IR, exception handlers initially have two parameters for the exception and the stack trace. In JavaScript: 1. Unwrap the caught value to get the exception that was thrown and use the unwrapped value in place of the exception parameter. 2. Get the stack trace from the (unwrapped) exception that was thrown. 3. Remove the stack trace parameter. BUG= R=asgerf@google.com Committed: https://code.google.com/p/dart/source/detail?r=45152

Patch Set 1 #

Total comments: 4

Patch Set 2 : Incorporated review comment.s #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -15 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 4 chunks +22 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 1 2 chunks +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 1 3 chunks +22 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/glue.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/unsugar.dart View 1 3 chunks +61 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Kevin Millikin (Google)
I'm using the Dart mutable variable analysis in the JS backend out of expediency, but ...
5 years, 8 months ago (2015-04-14 12:08:07 UTC) #2
asgerf
LGTM https://codereview.chromium.org/1083663005/diff/1/pkg/compiler/lib/src/js_backend/codegen/unsugar.dart File pkg/compiler/lib/src/js_backend/codegen/unsugar.dart (right): https://codereview.chromium.org/1083663005/diff/1/pkg/compiler/lib/src/js_backend/codegen/unsugar.dart#newcode18 pkg/compiler/lib/src/js_backend/codegen/unsugar.dart:18: /// - rewrite [IsTrue] in a [Branch] to ...
5 years, 8 months ago (2015-04-14 12:59:17 UTC) #3
Kevin Millikin (Google)
https://codereview.chromium.org/1083663005/diff/1/pkg/compiler/lib/src/js_backend/codegen/unsugar.dart File pkg/compiler/lib/src/js_backend/codegen/unsugar.dart (right): https://codereview.chromium.org/1083663005/diff/1/pkg/compiler/lib/src/js_backend/codegen/unsugar.dart#newcode18 pkg/compiler/lib/src/js_backend/codegen/unsugar.dart:18: /// - rewrite [IsTrue] in a [Branch] to do ...
5 years, 8 months ago (2015-04-15 07:52:23 UTC) #4
Kevin Millikin (Google)
5 years, 8 months ago (2015-04-15 07:56:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 45152 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698