Issue 108363003: We run phases in-between GVN and code motion, so we have to handle cases in the SsaCodeMotion phase…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 108363003: We run phases in-between GVN and code motion, so we have to handle cases in the SsaCodeMotion phase… (Closed)

Created:
7 years ago by ngeoffray

Modified:
7 years ago

Reviewers:
kasperl

CC:
reviews_dartlang.org, lukas

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

We run phases in-between GVN and code motion, so we have to handle cases in the SsaCodeMotion phase where two instructions can be GVN'ed. Committed: https://code.google.com/p/dart/source/detail?r=30977

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -3 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/inferrer/ir_type_inferrer.dart	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/optimize.dart	View		1 chunk	+7 lines, -3 lines	0 comments	Download
A	tests/language/code_motion_crash_test.dart	View	1	1 chunk	+43 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

ngeoffray

It was crashing for code from a customer. I added a regression test.

7 years ago (2013-12-08 12:39:49 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r30977 (presubmit successful).