Chromium Code Reviews

Issue 1083543004: Only consider a multichannel closed when the underlying channel closes. (Closed)

Created:
5 years, 8 months ago by nweiz
Modified:
5 years, 8 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Only consider a multichannel closed when the underlying channel closes. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/c1feea69d3490ce53580f9fdd4bd5061e5256cf8

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+1 line, -1 line)
M lib/src/util/multi_channel.dart View 1 chunk +1 line, -1 line 0 comments

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 8 months ago (2015-04-13 23:36:41 UTC) #1
kevmoo
lgtm
5 years, 8 months ago (2015-04-13 23:44:41 UTC) #2
nweiz
5 years, 8 months ago (2015-04-13 23:54:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c1feea69d3490ce53580f9fdd4bd5061e5256cf8 (presubmit successful).

Powered by Google App Engine