Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 1083413004: Make html-escape also escape < and > in attributes. (Closed)

Created:
5 years, 8 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 8 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Make html-escape also escape < and > in attributes. Unescaped < is not allowed in strict XHTML attributes. BUG= http://dartbug.com/21913 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=45278

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M sdk/lib/convert/html_escape.dart View 3 chunks +11 lines, -4 lines 0 comments Download
M tests/lib/convert/html_escape_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lasse Reichstein Nielsen
5 years, 8 months ago (2015-04-20 10:57:50 UTC) #2
Søren Gjesse
lgtm
5 years, 8 months ago (2015-04-20 11:00:41 UTC) #3
Lasse Reichstein Nielsen
5 years, 8 months ago (2015-04-20 11:01:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45278 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698