Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1083253002: Add normalizePath to Uri class. (Closed)

Created:
5 years, 8 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 8 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Add normalizePath to Uri class. The algorithm for removing '.' and '..' from a path is only available through the [resolve] method. This change makes it available directly as a function on a Uri, returning a new Uri if necessary. The current workaround is to do: var normalizedUri = new Uri().resolveUri(originalUri); R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=45163

Patch Set 1 #

Patch Set 2 : Add test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -2 lines) Patch
M sdk/lib/core/uri.dart View 2 chunks +20 lines, -1 line 0 comments Download
M sdk/lib/io/http.dart View 1 chunk +1 line, -1 line 0 comments Download
A tests/corelib/uri_normalize_path_test.dart View 1 1 chunk +54 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lasse Reichstein Nielsen
Will add tests.
5 years, 8 months ago (2015-04-15 09:32:42 UTC) #2
Søren Gjesse
lgtm with tests
5 years, 8 months ago (2015-04-15 09:36:01 UTC) #3
Lasse Reichstein Nielsen
5 years, 8 months ago (2015-04-15 11:56:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 45163 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698