Ignore HandshakeExceptions in HttpServer, as they are request(socket)-bound and not fatal for the s…

Ignore HandshakeExceptions in HttpServer, as they are request(socket)-bound and not fatal for the server.

BUG=https://code.google.com/p/dart/issues/detail?id=15419
R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31095

[Søren Gjesse, 2013-12-11 13:14:01]

lgtm

https://codereview.chromium.org/108323003/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/108323003/diff/1/sdk/lib/io/http_impl.dart#ne...
sdk/lib/io/http_impl.dart:2059: onError: (error) {
We could consider whether the SecureServerSocket should even generate these
errors. Maybe if explicitly requested.

https://codereview.chromium.org/108323003/diff/1/tests/standalone/io/https_se...
File tests/standalone/io/https_server_test.dart (right):

https://codereview.chromium.org/108323003/diff/1/tests/standalone/io/https_se...
tests/standalone/io/https_server_test.dart:82: var data = "GET /
HTTP/1.1\r\nContent-Length: 0\r\n\r\n";
Send "Invalid TLS handsahke" or something else instead of a HTTP request to
clarify what is going on?

[Anders Johnsen, 2013-12-12 10:36:29]

PTAL

https://codereview.chromium.org/108323003/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/108323003/diff/1/sdk/lib/io/http_impl.dart#ne...
sdk/lib/io/http_impl.dart:2059: onError: (error) {
On 2013/12/11 13:14:01, Søren Gjesse wrote:
> We could consider whether the SecureServerSocket should even generate these
> errors. Maybe if explicitly requested.

The general approach we've had so far is that the basic elements will emit any
error that may usable. We've then used WebSocket and HttpServer/HttpClient to
filter out uneeded. Do you think we should move to an approach where the user
should configure what errors to get?

[Anders Johnsen, 2013-12-12 10:36:47]

https://codereview.chromium.org/108323003/diff/1/tests/standalone/io/https_se...
File tests/standalone/io/https_server_test.dart (right):

https://codereview.chromium.org/108323003/diff/1/tests/standalone/io/https_se...
tests/standalone/io/https_server_test.dart:82: var data = "GET /
HTTP/1.1\r\nContent-Length: 0\r\n\r\n";
On 2013/12/11 13:14:01, Søren Gjesse wrote:
> Send "Invalid TLS handsahke" or something else instead of a HTTP request to
> clarify what is going on?

Done.

[Anders Johnsen, 2013-12-12 14:21:47]

Committed patchset #3 manually as r31095 (presubmit successful).