Deprecate visitAssertSend and visitTypePrefixSend

Deprecate visitAssertSend and visitTypePrefixSend

BUG=
R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45157

[Johnni Winther, 2015-04-14 14:00:53]

johnniwinther@google.com changed reviewers:
+ karlklose@google.com

[karlklose, 2015-04-15 07:18:03]

LGTM.

https://codereview.chromium.org/1083063002/diff/1/pkg/compiler/lib/src/inferr...
File pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart (right):

https://codereview.chromium.org/1083063002/diff/1/pkg/compiler/lib/src/inferr...
pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart:1029: new
ArgumentsTypes([expression.accept(this)], null);
Add type argument to list literal.

https://codereview.chromium.org/1083063002/diff/1/pkg/compiler/lib/src/resolv...
File pkg/compiler/lib/src/resolved_visitor.dart (right):

https://codereview.chromium.org/1083063002/diff/1/pkg/compiler/lib/src/resolv...
pkg/compiler/lib/src/resolved_visitor.dart:42: @deprecated
What is the deprecation strategy for these methods?

https://codereview.chromium.org/1083063002/diff/1/pkg/compiler/lib/src/ssa/bu...
File pkg/compiler/lib/src/ssa/builder.dart (right):

https://codereview.chromium.org/1083063002/diff/1/pkg/compiler/lib/src/ssa/bu...
pkg/compiler/lib/src/ssa/builder.dart:4646: }
    if (element == compiler.identicalFunction) {
      pushWithPosition(
            new HIdentity(inputs[0], inputs[1], null, ...);
    } else {
      pushInvokeStatic(node, element, inputs);
    }

[Johnni Winther, 2015-04-15 10:37:10]

https://codereview.chromium.org/1083063002/diff/1/pkg/compiler/lib/src/inferr...
File pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart (right):

https://codereview.chromium.org/1083063002/diff/1/pkg/compiler/lib/src/inferr...
pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart:1029: new
ArgumentsTypes([expression.accept(this)], null);
On 2015/04/15 07:18:02, karlklose wrote:
> Add type argument to list literal.

Done.

https://codereview.chromium.org/1083063002/diff/1/pkg/compiler/lib/src/resolv...
File pkg/compiler/lib/src/resolved_visitor.dart (right):

https://codereview.chromium.org/1083063002/diff/1/pkg/compiler/lib/src/resolv...
pkg/compiler/lib/src/resolved_visitor.dart:42: @deprecated
On 2015/04/15 07:18:03, karlklose wrote:
> What is the deprecation strategy for these methods?

When SsaBuilder and InferrerVisitors no longer uses ResolvedVisitor methods.

https://codereview.chromium.org/1083063002/diff/1/pkg/compiler/lib/src/ssa/bu...
File pkg/compiler/lib/src/ssa/builder.dart (right):

https://codereview.chromium.org/1083063002/diff/1/pkg/compiler/lib/src/ssa/bu...
pkg/compiler/lib/src/ssa/builder.dart:4646: }
On 2015/04/15 07:18:03, karlklose wrote:
>     if (element == compiler.identicalFunction) {
>       pushWithPosition(
>             new HIdentity(inputs[0], inputs[1], null, ...);
>     } else {
>       pushInvokeStatic(node, element, inputs);
>     }

Done.

[Johnni Winther, 2015-04-15 10:44:43]

Committed patchset #2 (id:20001) manually as 45157 (presubmit successful).