Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 1083043002: cps-ir: Register instantiated type at InvokeConstructor. (Closed)

Created:
5 years, 8 months ago by asgerf
Modified:
5 years, 8 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, floitsch
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

cps-ir: Register instantiated type at InvokeConstructor. This is a symptom of a larger issue that will arise when we try to inline InvokeConstructor invocations. I've left a TODO to consider when we start to look at inlining. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=45135

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
asgerf
I would add a test case, but our current infrastructure for this backend does not ...
5 years, 8 months ago (2015-04-14 11:57:29 UTC) #2
karlklose
LGTM, thanks!
5 years, 8 months ago (2015-04-14 12:09:25 UTC) #3
asgerf
5 years, 8 months ago (2015-04-14 12:29:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45135 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698