Issue 108293002: Fix a crash in the compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 108293002: Fix a crash in the compiler. (Closed)

Created:
7 years ago by ngeoffray

Modified:
7 years ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix a crash in the compiler. joinedLocals is populated with phis and the [thisValue], but [thisValue] could be a phi as well. So the check has to be whether the element of the local is the this element. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=30949

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -1 line)			Patch
	M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	A	tests/language/phi_merge_test.dart	View		1 chunk	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r30949 (presubmit successful).

Expand Messages | Collapse Messages