Move LibraryUnitTarget into API.

Move LibraryUnitTarget into API.

We need this Target to use it in the Angular plugin.

Also increment version with the goal to publish the analyzer package and use in the Angular plugin.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=45192

[Paul Berry, 2015-04-15 21:35:25]

On 2015/04/15 21:24:09, scheglov wrote:

I haven't had a chance to review the code yet, but a quick comment on
incrementing the version number: are you intending to publish version 0.24.5
immediately upon committing this CL?  If so, then incrementing the version to
0.24.5 is probably ok.  However, the process Bob recommends is that in a change
like this, we should upgrade the version from 0.24.4 to 0.24.5-dev, and then
later, when we publish, we change from 0.24.5-dev to 0.24.5.  In essence,
version X.Y.Z-dev means "this is an unpublished version which we intend to
publish as version X.Y.Z".

[Brian Wilkerson, 2015-04-15 21:41:37]

https://codereview.chromium.org/1082913007/diff/1/pkg/analyzer/lib/task/dart....
File pkg/analyzer/lib/task/dart.dart (right):

https://codereview.chromium.org/1082913007/diff/1/pkg/analyzer/lib/task/dart....
pkg/analyzer/lib/task/dart.dart:126: * A pair of a library [Source] and a unit
[Source] in this library.
Perhaps:

A specific compilation unit in a specific library. This kind of target is
associated with information about a compilation unit that differs based on the
library that the unit is a part of. For example, the result of resolving a
compilation unit depends on the imports, which can change if a single part is
included in more than one library.

https://codereview.chromium.org/1082913007/diff/1/pkg/analyzer/lib/task/dart....
pkg/analyzer/lib/task/dart.dart:128: class LibraryUnitTarget implements
AnalysisTarget {
I'd prefer a more meaningful name, but I'm having trouble thinking of a good
one. I keep coming up with things like "LibrarySpecificUnit" or
"LibraryQualifiedUnit". "Part" seems too short, and doesn't really fit the
defining compilation unit. Hopefully someone else has a better idea.

https://codereview.chromium.org/1082913007/diff/1/pkg/analyzer/lib/task/dart....
pkg/analyzer/lib/task/dart.dart:129: final Source library;
This needs a comment. Even something as simple as

The defining compilation unit of the library in which the [unit] is analyzed.

https://codereview.chromium.org/1082913007/diff/1/pkg/analyzer/lib/task/dart....
pkg/analyzer/lib/task/dart.dart:130: final Source unit;
This needs a comment.

https://codereview.chromium.org/1082913007/diff/1/pkg/analyzer/lib/task/dart....
pkg/analyzer/lib/task/dart.dart:132: LibraryUnitTarget(this.library, this.unit);
This needs a comment.

[Brian Wilkerson, 2015-04-15 21:46:12]

> ... are you intending to publish version 0.24.5 immediately upon committing
this CL?

Based on "Also increment version with the goal to publish the analyzer package
and use in the Angular plugin.", I was guessing that the answer is "yes".

But that raises another concern: we want to be careful that we're not pushing a
new version every time we discover something more we need for the Angular
support. There's a cost to our clients of having frequent small revisions.
Can/should we develop the Angular support against head for a while before
pushing a new version?

[scheglov, 2015-04-15 21:50:54]

On 2015/04/15 21:46:12, Brian Wilkerson wrote:
> > ... are you intending to publish version 0.24.5 immediately upon committing
> this CL?
> 
> Based on "Also increment version with the goal to publish the analyzer package
> and use in the Angular plugin.", I was guessing that the answer is "yes".
> 
> But that raises another concern: we want to be careful that we're not pushing
a
> new version every time we discover something more we need for the Angular
> support. There's a cost to our clients of having frequent small revisions.
> Can/should we develop the Angular support against head for a while before
> pushing a new version?

I don't see a way to do this without publishing a t all.
We need a machine-independent way to refer a newer version.
Is -dev any better?

I'm going to make analyzer_plugin to be its own package inside of Angular.
We need to do this for server_plugin anyway - we don't want Angular to depend on
the analysis_server plugin.
So, we could reference use -dev versions while we are developing.

[scheglov, 2015-04-15 23:27:51]

PTAL

Yes, I'm going to publish it right after commit.

https://codereview.chromium.org/1082913007/diff/1/pkg/analyzer/lib/task/dart....
File pkg/analyzer/lib/task/dart.dart (right):

https://codereview.chromium.org/1082913007/diff/1/pkg/analyzer/lib/task/dart....
pkg/analyzer/lib/task/dart.dart:126: * A pair of a library [Source] and a unit
[Source] in this library.
On 2015/04/15 21:41:37, Brian Wilkerson wrote:
> Perhaps:
> 
> A specific compilation unit in a specific library. This kind of target is
> associated with information about a compilation unit that differs based on the
> library that the unit is a part of. For example, the result of resolving a
> compilation unit depends on the imports, which can change if a single part is
> included in more than one library.

Done.

https://codereview.chromium.org/1082913007/diff/1/pkg/analyzer/lib/task/dart....
pkg/analyzer/lib/task/dart.dart:128: class LibraryUnitTarget implements
AnalysisTarget {
On 2015/04/15 21:41:37, Brian Wilkerson wrote:
> I'd prefer a more meaningful name, but I'm having trouble thinking of a good
> one. I keep coming up with things like "LibrarySpecificUnit" or
> "LibraryQualifiedUnit". "Part" seems too short, and doesn't really fit the
> defining compilation unit. Hopefully someone else has a better idea.

Done.

https://codereview.chromium.org/1082913007/diff/1/pkg/analyzer/lib/task/dart....
pkg/analyzer/lib/task/dart.dart:129: final Source library;
On 2015/04/15 21:41:37, Brian Wilkerson wrote:
> This needs a comment. Even something as simple as
> 
> The defining compilation unit of the library in which the [unit] is analyzed.

Done.

https://codereview.chromium.org/1082913007/diff/1/pkg/analyzer/lib/task/dart....
pkg/analyzer/lib/task/dart.dart:130: final Source unit;
On 2015/04/15 21:41:37, Brian Wilkerson wrote:
> This needs a comment.

Done.

https://codereview.chromium.org/1082913007/diff/1/pkg/analyzer/lib/task/dart....
pkg/analyzer/lib/task/dart.dart:132: LibraryUnitTarget(this.library, this.unit);
On 2015/04/15 21:41:37, Brian Wilkerson wrote:
> This needs a comment.

Done.

[Brian Wilkerson, 2015-04-16 00:00:43]

LGTM

[scheglov, 2015-04-16 00:06:30]

Committed patchset #2 (id:20001) manually as 45192 (presubmit successful).