Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1082833003: Revert "Make the mutable variables local to an IR builder instead of global." (Closed)

Created:
5 years, 8 months ago by Kevin Millikin (Google)
Modified:
5 years, 8 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Revert "Make the mutable variables local to an IR builder instead of global." This reverts SVN revsion 45272. It breaks dart2dart and the S-expression parsing tests. R=asgerf@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=45273

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -59 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 13 chunks +73 lines, -59 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Google)
5 years, 8 months ago (2015-04-20 09:26:48 UTC) #1
asgerf
lgtm
5 years, 8 months ago (2015-04-20 09:27:22 UTC) #2
Kevin Millikin (Google)
5 years, 8 months ago (2015-04-20 09:28:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45273 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698