Issue 1082203003: VM: Fix bug in stack map builder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1082203003: VM: Fix bug in stack map builder. (Closed)

Created:
5 years, 8 months ago by Florian Schneider

Modified:
5 years, 8 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

VM: Fix bug in stack map builder. It did not crash because unoptimized code never has both untagged cpu registers and FPU registers on the stack, but resulted in unnecessary alloction of empty stackmaps in unoptimized code. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=45137

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	runtime/vm/flow_graph_compiler.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	runtime/vm/locations.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Florian Schneider

5 years, 8 months ago (2015-04-14 12:37:55 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r45137 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages