Reduce footprint of HTML Timer by not creating a "cancel" closure.

Reduce footprint of HTML Timer by not creating a "cancel" closure.

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30982

Committed: https://code.google.com/p/dart/source/detail?r=30984

[floitsch, 2013-12-06 14:11:23]

LGTM.

https://codereview.chromium.org/108213003/diff/1/tools/dom/src/native_DOMImpl...
File tools/dom/src/native_DOMImplementation.dart (right):

https://codereview.chromium.org/108213003/diff/1/tools/dom/src/native_DOMImpl...
tools/dom/src/native_DOMImplementation.dart:536: var _state;
type as "int", and explain how it is used.

https://codereview.chromium.org/108213003/diff/1/tools/dom/src/native_DOMImpl...
tools/dom/src/native_DOMImplementation.dart:542: }), milliSeconds) * 2 +
_STATE_INTERVAL;
I'm surprised we typed the "id" as integer.
All the documentation I found refers to it as "value".

If we stick with integers (which is probably ok, since it would break way too
many JS programs if it changed), I would prefer the << operation. After all we
are dealing with bits here.

https://codereview.chromium.org/108213003/diff/1/tools/dom/src/native_DOMImpl...
tools/dom/src/native_DOMImplementation.dart:553: int id = state ~/ 2;
ditto.

[floitsch, 2013-12-06 14:13:23]

https://codereview.chromium.org/108213003/diff/1/tools/dom/src/native_DOMImpl...
File tools/dom/src/native_DOMImplementation.dart (right):

https://codereview.chromium.org/108213003/diff/1/tools/dom/src/native_DOMImpl...
tools/dom/src/native_DOMImplementation.dart:542: }), milliSeconds) * 2 +
_STATE_INTERVAL;
On 2013/12/06 14:11:23, floitsch wrote:
> I'm surprised we typed the "id" as integer.
> All the documentation I found refers to it as "value".
> 
> If we stick with integers (which is probably ok, since it would break way too
> many JS programs if it changed), I would prefer the << operation. After all we
> are dealing with bits here.

Hmm. Since no JS implementation guarantees the range of the integer, we should
stick with the "* 2" approach.
So ignore this comment.
I also found that the documentation for IE explicitly states that the returned
value is an integer.

[Lasse Reichstein Nielsen, 2013-12-09 10:17:25]

https://codereview.chromium.org/108213003/diff/1/tools/dom/src/native_DOMImpl...
File tools/dom/src/native_DOMImplementation.dart (right):

https://codereview.chromium.org/108213003/diff/1/tools/dom/src/native_DOMImpl...
tools/dom/src/native_DOMImplementation.dart:542: }), milliSeconds) * 2 +
_STATE_INTERVAL;
That was my thought too. I think it may always be an int32, but that won't help
us here.

[Lasse Reichstein Nielsen, 2013-12-09 10:40:41]

Committed patchset #1 manually as r30982 (presubmit successful).

[Lasse Reichstein Nielsen, 2013-12-09 11:39:46]

Committed patchset #2 manually as r30984 (presubmit successful).