Visit arguments of invalid TypeLiteralSends during inference

Visit arguments of invalid TypeLiteralSends during inference

BUG= http://dartbug.com/23264
R=johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45315

[Siggi Cherem (dart-lang), 2015-04-21 02:18:54]

Patchset #1 (id:1) has been deleted

[Siggi Cherem (dart-lang), 2015-04-21 02:21:18]

sigmund@google.com changed reviewers:
+ johnniwinther@google.com

[Siggi Cherem (dart-lang), 2015-04-21 02:21:19]

https://codereview.chromium.org/1081873005/diff/20001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart (right):

https://codereview.chromium.org/1081873005/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart:1036: if (node.isCall)
{
I added this because it seems that the ssa/builder already has support for
generating code in this case. However, do we need to? Or could we simply
generate the invalid call directly and ignore the arguments altogether?

https://codereview.chromium.org/1081873005/diff/20001/tests/compiler/dart2js_...
File tests/compiler/dart2js_extra/23264_test.dart (right):

https://codereview.chromium.org/1081873005/diff/20001/tests/compiler/dart2js_...
tests/compiler/dart2js_extra/23264_test.dart:4: main() => Expect.throws(() =>
A(const [])); // oops, `new` is missing!
because of the missing new, we weren't visiting inside the arguments and we
later crash when we found there is no ListTypeInformation for the `const []`.

[Johnni Winther, 2015-04-21 08:15:13]

lgtm

https://codereview.chromium.org/1081873005/diff/20001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart (right):

https://codereview.chromium.org/1081873005/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart:1036: if (node.isCall)
{
On 2015/04/21 02:21:19, Siggi Cherem (dart-lang) wrote:
> I added this because it seems that the ssa/builder already has support for
> generating code in this case. However, do we need to? Or could we simply
> generate the invalid call directly and ignore the arguments altogether?

The fix is good. This needs to happen at runtime since the exception can be
caught.

[Siggi Cherem (dart-lang), 2015-04-21 15:36:48]

Committed patchset #1 (id:20001) manually as 45315 (presubmit successful).