Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1081533002: Re-add exit_codes import to runner_test. (Closed)

Created:
5 years, 8 months ago by nweiz
Modified:
5 years, 8 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/runner/browser/runner_test.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M test/runner/runner_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
5 years, 8 months ago (2015-04-10 22:40:34 UTC) #1
kevmoo
LGTM ...but remove the import from test/browser/runner_test.dart That was my oops
5 years, 8 months ago (2015-04-10 23:22:08 UTC) #2
nweiz
Code review changes
5 years, 8 months ago (2015-04-10 23:32:26 UTC) #3
nweiz
5 years, 8 months ago (2015-04-10 23:32:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
05272f52da0c524fa78352dfe0422eb9240330f5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698