Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1080903003: Detect an expired content shell and emit a nice error. (Closed)

Created:
5 years, 8 months ago by nweiz
Modified:
5 years, 8 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Detect an expired content shell and emit a nice error. Closes #69 R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/263edc08f709ff53c0dde0bfc88503696a90b121

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1 line) Patch
M lib/src/runner/browser/content_shell.dart View 1 2 chunks +25 lines, -0 lines 0 comments Download
M lib/src/runner/browser/server.dart View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
5 years, 8 months ago (2015-04-14 22:38:23 UTC) #1
kevmoo
lgtm https://codereview.chromium.org/1080903003/diff/1/lib/src/runner/browser/content_shell.dart File lib/src/runner/browser/content_shell.dart (right): https://codereview.chromium.org/1080903003/diff/1/lib/src/runner/browser/content_shell.dart#newcode64 lib/src/runner/browser/content_shell.dart:64: throw new ApplicationException( Add a TODO to point ...
5 years, 8 months ago (2015-04-14 22:52:12 UTC) #2
nweiz
Code review changes
5 years, 8 months ago (2015-04-14 23:05:13 UTC) #3
nweiz
https://codereview.chromium.org/1080903003/diff/1/lib/src/runner/browser/content_shell.dart File lib/src/runner/browser/content_shell.dart (right): https://codereview.chromium.org/1080903003/diff/1/lib/src/runner/browser/content_shell.dart#newcode64 lib/src/runner/browser/content_shell.dart:64: throw new ApplicationException( On 2015/04/14 22:52:12, kevmoo wrote: > ...
5 years, 8 months ago (2015-04-14 23:05:31 UTC) #4
nweiz
5 years, 8 months ago (2015-04-14 23:05:46 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
263edc08f709ff53c0dde0bfc88503696a90b121 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698