Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1080653003: Create a public API for contributing fixes and make fixes pluggable (Closed)

Created:
5 years, 8 months ago by Brian Wilkerson
Modified:
5 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Create a public API for contributing fixes and make fixes pluggable R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=45079

Patch Set 1 #

Patch Set 2 : Missed clean-up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+547 lines, -303 lines) Patch
A pkg/analysis_server/lib/edit/fix/fix_core.dart View 1 chunk +94 lines, -0 lines 0 comments Download
A pkg/analysis_server/lib/edit/fix/fix_dart.dart View 1 chunk +41 lines, -0 lines 0 comments Download
A pkg/analysis_server/lib/plugin/fix.dart View 1 chunk +22 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 4 chunks +9 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/plugin/server_plugin.dart View 6 chunks +45 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix.dart View 1 3 chunks +28 lines, -40 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 45 chunks +60 lines, -46 lines 0 comments Download
M pkg/analysis_server/test/edit/assists_test.dart View 2 chunks +6 lines, -1 line 0 comments Download
M pkg/analysis_server/test/edit/fixes_test.dart View 2 chunks +6 lines, -1 line 0 comments Download
M pkg/analysis_server/test/edit/format_test.dart View 3 chunks +20 lines, -15 lines 0 comments Download
M pkg/analysis_server/test/edit/refactoring_test.dart View 6 chunks +24 lines, -16 lines 0 comments Download
M pkg/analysis_server/test/edit/sort_members_test.dart View 2 chunks +6 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 179 chunks +186 lines, -179 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
5 years, 8 months ago (2015-04-10 20:39:57 UTC) #2
scheglov
LGTM
5 years, 8 months ago (2015-04-10 20:51:43 UTC) #3
Brian Wilkerson
5 years, 8 months ago (2015-04-10 21:01:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 45079 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698