Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1131)

Issue 1080123002: add benchmarks.dart which allows you to easily benchmark transformer code (Closed)

Created:
5 years, 8 months ago by jakemac
Modified:
5 years, 8 months ago
CC:
reviews_dartlang.org, tjblasi
Base URL:
git@github.com:dart-lang/code-transformers.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

add benchmarks.dart which allows you to easily benchmark transformer code R=sigmund@google.com Committed: https://github.com/dart-lang/code-transformers/commit/b548ea881285f0ae0b94ac4500c6c529f249e338

Patch Set 1 #

Patch Set 2 : update pubspec/changelog #

Patch Set 3 : add missing return #

Total comments: 4

Patch Set 4 : code review updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -1 line) Patch
M CHANGELOG.md View 1 1 chunk +5 lines, -0 lines 0 comments Download
A lib/benchmarks.dart View 1 2 3 1 chunk +76 lines, -0 lines 0 comments Download
A lib/src/async_benchmark_base.dart View 1 2 3 1 chunk +71 lines, -0 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
A test/benchmarks_test.dart View 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jakemac
5 years, 8 months ago (2015-04-13 20:17:45 UTC) #2
Siggi Cherem (dart-lang)
https://codereview.chromium.org/1080123002/diff/40001/lib/benchmarks.dart File lib/benchmarks.dart (right): https://codereview.chromium.org/1080123002/diff/40001/lib/benchmarks.dart#newcode76 lib/benchmarks.dart:76: return done.future; I think you can replace the completer ...
5 years, 8 months ago (2015-04-13 20:46:02 UTC) #3
jakemac
https://codereview.chromium.org/1080123002/diff/40001/lib/benchmarks.dart File lib/benchmarks.dart (right): https://codereview.chromium.org/1080123002/diff/40001/lib/benchmarks.dart#newcode76 lib/benchmarks.dart:76: return done.future; On 2015/04/13 20:46:02, Siggi Cherem (dart-lang) wrote: ...
5 years, 8 months ago (2015-04-13 21:04:19 UTC) #4
Siggi Cherem (dart-lang)
lgtm
5 years, 8 months ago (2015-04-13 23:56:47 UTC) #5
jakemac
5 years, 8 months ago (2015-04-14 16:25:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
b548ea881285f0ae0b94ac4500c6c529f249e338 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698