Chromium Code Reviews

Issue 1080103002: Add support for running tests on Dartium. (Closed)

Created:
5 years, 8 months ago by nweiz
Modified:
5 years, 8 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@wip.dartium
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add support for running tests on Dartium. Closes #60 R=kevmoo@google.com BUG= Committed: https://github.com/dart-lang/test/commit/e8df0d655a066343fbf7bc53ca2d1ba17dbda480

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix a race condition. #

Patch Set 4 : . #

Total comments: 2

Patch Set 5 : Code review changes #

Unified diffs Side-by-side diffs Stats (+563 lines, -635 lines)
M CHANGELOG.md View 1 chunk +2 lines, -0 lines 0 comments
M README.md View 2 chunks +20 lines, -5 lines 0 comments
M lib/src/backend/test_platform.dart View 2 chunks +5 lines, -1 line 0 comments
M lib/src/runner/browser/browser_manager.dart View 1 chunk +1 line, -1 line 0 comments
A + lib/src/runner/browser/dartium.dart View 6 chunks +36 lines, -31 lines 0 comments
M lib/src/runner/browser/iframe_listener.dart View 2 chunks +9 lines, -17 lines 0 comments
M lib/src/runner/browser/server.dart View 6 chunks +21 lines, -5 lines 0 comments
M lib/src/runner/browser/static/host.dart View 1 chunk +24 lines, -24 lines 0 comments
M lib/src/runner/browser/static/host.dart.js View 69 chunks +365 lines, -486 lines 0 comments
M lib/src/runner/browser/static/host.dart.js.map View 1 chunk +2 lines, -2 lines 0 comments
M pubspec.yaml View 1 chunk +1 line, -0 lines 0 comments
A + test/runner/browser/dartium_test.dart View 4 chunks +45 lines, -45 lines 0 comments
M test/runner/browser/runner_test.dart View 4 chunks +32 lines, -18 lines 0 comments

Messages

Total messages: 8 (0 generated)
nweiz
5 years, 8 months ago (2015-04-13 19:30:40 UTC) #1
kevmoo
lgtm
5 years, 8 months ago (2015-04-13 20:02:35 UTC) #2
nweiz
On 2015/04/13 20:02:35, kevmoo wrote: > lgtm PTAL I was playing around with this a ...
5 years, 8 months ago (2015-04-13 20:28:01 UTC) #3
kevmoo
...and recompile host.js? https://codereview.chromium.org/1080103002/diff/60001/lib/src/runner/browser/static/host.dart File lib/src/runner/browser/static/host.dart (right): https://codereview.chromium.org/1080103002/diff/60001/lib/src/runner/browser/static/host.dart#newcode132 lib/src/runner/browser/static/host.dart:132: outputController.stream.listen((message) { readyCompleter.future.then?
5 years, 8 months ago (2015-04-13 20:36:24 UTC) #4
nweiz
Code review changes
5 years, 8 months ago (2015-04-13 20:39:03 UTC) #5
nweiz
https://codereview.chromium.org/1080103002/diff/60001/lib/src/runner/browser/static/host.dart File lib/src/runner/browser/static/host.dart (right): https://codereview.chromium.org/1080103002/diff/60001/lib/src/runner/browser/static/host.dart#newcode132 lib/src/runner/browser/static/host.dart:132: outputController.stream.listen((message) { On 2015/04/13 20:36:24, kevmoo wrote: > readyCompleter.future.then? ...
5 years, 8 months ago (2015-04-13 20:39:08 UTC) #6
kevmoo
lgtm
5 years, 8 months ago (2015-04-13 21:32:47 UTC) #7
nweiz
5 years, 8 months ago (2015-04-13 22:28:19 UTC) #8
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
e8df0d655a066343fbf7bc53ca2d1ba17dbda480 (presubmit successful).

Powered by Google App Engine