Make HForeignCode 'isAllocation' property available to optimization

Make HForeignCode 'isAllocation' property available to optimization

The main difference seen is slightly better codegen around a few box allocations due to store-forwarding across calls because the allocation is now known to be unaliased.

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45118

[sra1, 2015-04-11 20:51:19]

sra@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2015-04-13 07:54:57]

LGTM.

https://chromiumcodereview.appspot.com/1079803002/diff/1/pkg/compiler/lib/src...
File pkg/compiler/lib/src/ssa/nodes.dart (right):

https://chromiumcodereview.appspot.com/1079803002/diff/1/pkg/compiler/lib/src...
pkg/compiler/lib/src/ssa/nodes.dart:1760: bool isAllocation() => nativeBehavior
!= null &&
this is a getter name. -> should be a getter.
same is true for all the other predicates.

I guess we should do this cleanup in a separate CL.

[sra1, 2015-04-13 17:12:43]

https://chromiumcodereview.appspot.com/1079803002/diff/1/pkg/compiler/lib/src...
File pkg/compiler/lib/src/ssa/nodes.dart (right):

https://chromiumcodereview.appspot.com/1079803002/diff/1/pkg/compiler/lib/src...
pkg/compiler/lib/src/ssa/nodes.dart:1760: bool isAllocation() => nativeBehavior
!= null &&
On 2015/04/13 07:54:56, floitsch wrote:
> this is a getter name. -> should be a getter.
> same is true for all the other predicates.
> 
> I guess we should do this cleanup in a separate CL.

Done.  At first I thought I might need an argument.

[sra1, 2015-04-13 19:29:29]

Committed patchset #2 (id:20001) manually as 45118 (presubmit successful).