Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1079533002: Handle SendSet and NewExpression through NewResolvedVisitor. (Closed)

Created:
5 years, 8 months ago by Johnni Winther
Modified:
5 years, 8 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, Harry Terkelsen, Siggi Cherem (dart-lang)
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Handle SendSet and NewExpression through NewResolvedVisitor. This allows for the handling assignment and new expression through the SemanticSendVisitor methods in SsaBuilder and InferrerVisitor(s). BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=45091 Reverted: https://code.google.com/p/dart/source/detail?r=45093 Committed: https://code.google.com/p/dart/source/detail?r=45138

Patch Set 1 #

Patch Set 2 : Cleanup. #

Patch Set 3 : Fix problems with prefix/postfix and erroneous const invocations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -35 lines) Patch
M pkg/compiler/lib/src/dart_backend/placeholder_collector.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_visitor.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/send_resolver.dart View 1 2 1 chunk +15 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_structure.dart View 1 2 2 chunks +9 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolved_visitor.dart View 1 2 12 chunks +95 lines, -25 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 2 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Johnni Winther
5 years, 8 months ago (2015-04-10 14:39:19 UTC) #2
karlklose
LGTM.
5 years, 8 months ago (2015-04-13 08:05:02 UTC) #3
Johnni Winther
Committed patchset #2 (id:20001) manually as 45091 (presubmit successful).
5 years, 8 months ago (2015-04-13 09:48:32 UTC) #4
Johnni Winther
PTAL @ the last patch
5 years, 8 months ago (2015-04-13 13:49:15 UTC) #5
Johnni Winther
ping
5 years, 8 months ago (2015-04-14 09:07:36 UTC) #6
karlklose
LGTM.
5 years, 8 months ago (2015-04-14 10:18:30 UTC) #7
Johnni Winther
5 years, 8 months ago (2015-04-14 12:57:11 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 45138 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698