Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1079253002: Use native behavior for dead code elimination (Closed)

Created:
5 years, 8 months ago by sra1
Modified:
5 years, 8 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Use native behavior for dead code elimination - Unused pure instructions are removed - noSuchMethod-on-null-guards R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=45110

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -6 lines) Patch
M pkg/compiler/lib/src/native/behavior.dart View 1 chunk +16 lines, -0 lines 2 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 1 chunk +5 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 2 chunks +8 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/js_lib/js_number.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/js_lib/js_string.dart View 2 chunks +7 lines, -3 lines 0 comments Download
A tests/compiler/dart2js/js_spec_optimization_test.dart View 1 chunk +94 lines, -0 lines 2 comments Download

Messages

Total messages: 7 (3 generated)
sra1
Finally we can optimize t1 = this.tokenizer.command; t1.toString; cmd = t1.toLowerCase(); to cmd = this.tokenizer.command.toLowerCase()
5 years, 8 months ago (2015-04-10 22:18:45 UTC) #3
floitsch
LGTM. https://codereview.chromium.org/1079253002/diff/40001/pkg/compiler/lib/src/native/behavior.dart File pkg/compiler/lib/src/native/behavior.dart (right): https://codereview.chromium.org/1079253002/diff/40001/pkg/compiler/lib/src/native/behavior.dart#newcode42 pkg/compiler/lib/src/native/behavior.dart:42: bool get onlyNullNSMGuard => this == MAY_THROW_ONLY_ON_FIRST_ARGUMENT_ACCESS; nit: ...
5 years, 8 months ago (2015-04-13 08:07:14 UTC) #5
sra1
Committed patchset #1 (id:40001) manually as 45110 (presubmit successful).
5 years, 8 months ago (2015-04-13 16:30:50 UTC) #6
sra1
5 years, 8 months ago (2015-04-13 23:59:05 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/1079253002/diff/40001/pkg/compiler/lib/src/na...
File pkg/compiler/lib/src/native/behavior.dart (right):

https://codereview.chromium.org/1079253002/diff/40001/pkg/compiler/lib/src/na...
pkg/compiler/lib/src/native/behavior.dart:42: bool get onlyNullNSMGuard => this
== MAY_THROW_ONLY_ON_FIRST_ARGUMENT_ACCESS;
On 2015/04/13 08:07:14, floitsch wrote:
> nit: isOnlyNullNSMGuard

Done.

https://codereview.chromium.org/1079253002/diff/40001/tests/compiler/dart2js/...
File tests/compiler/dart2js/js_spec_optimization_test.dart (right):

https://codereview.chromium.org/1079253002/diff/40001/tests/compiler/dart2js/...
tests/compiler/dart2js/js_spec_optimization_test.dart:23:
print(JS('returns:bool;effects:none;depends:all;throws:never', 'Wasp') is bool);
On 2015/04/13 08:07:14, floitsch wrote:
> nit: long line.

Done.

Powered by Google App Engine
This is Rietveld 408576698