Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1079233002: Simplify restoring of saved try contexts in async code by passing around the (Closed)

Created:
5 years, 8 months ago by regis
Modified:
5 years, 8 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Simplify restoring of saved try contexts in async code by passing around the relevant variables instead of scopes and try indices. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=45081

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -142 lines) Patch
M runtime/vm/ast.h View 2 chunks +18 lines, -16 lines 0 comments Download
M runtime/vm/ast_transformer.h View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/ast_transformer.cc View 2 chunks +13 lines, -33 lines 0 comments Download
M runtime/vm/parser.h View 1 chunk +6 lines, -5 lines 0 comments Download
M runtime/vm/parser.cc View 13 chunks +137 lines, -84 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
regis
5 years, 8 months ago (2015-04-10 22:02:07 UTC) #2
hausner
lgtm
5 years, 8 months ago (2015-04-10 22:14:01 UTC) #3
regis
5 years, 8 months ago (2015-04-10 22:15:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r45081 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698