Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1079163009: Fix script-view. Hide annotations except the current position when debugging. (Closed)

Created:
5 years, 8 months ago by rmacnak
Modified:
5 years, 8 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Fix script-view. Hide annotations except the current position when debugging. Committed: https://code.google.com/p/dart/source/detail?r=45364

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -37 lines) Patch
M runtime/observatory/lib/src/elements/debugger.html View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/script_inset.dart View 1 5 chunks +36 lines, -33 lines 0 comments Download
M runtime/observatory/lib/src/elements/script_view.html View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
5 years, 8 months ago (2015-04-22 20:34:24 UTC) #2
Cutch
LGTMwC https://codereview.chromium.org/1079163009/diff/1/runtime/observatory/lib/src/elements/script_inset.dart File runtime/observatory/lib/src/elements/script_inset.dart (right): https://codereview.chromium.org/1079163009/diff/1/runtime/observatory/lib/src/elements/script_inset.dart#newcode507 runtime/observatory/lib/src/elements/script_inset.dart:507: if (inDebuggerContext || (line == null) || (line.hits ...
5 years, 8 months ago (2015-04-22 20:40:34 UTC) #3
rmacnak
https://codereview.chromium.org/1079163009/diff/1/runtime/observatory/lib/src/elements/script_inset.dart File runtime/observatory/lib/src/elements/script_inset.dart (right): https://codereview.chromium.org/1079163009/diff/1/runtime/observatory/lib/src/elements/script_inset.dart#newcode507 runtime/observatory/lib/src/elements/script_inset.dart:507: if (inDebuggerContext || (line == null) || (line.hits == ...
5 years, 8 months ago (2015-04-22 20:49:27 UTC) #4
rmacnak
5 years, 8 months ago (2015-04-22 20:49:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 45364 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698