Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 1078943003: add suggestions for named param (Closed)

Created:
5 years, 8 months ago by danrubel
Modified:
5 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

add suggestions for named param BUG=dartbug.com/22403 R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=45047

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+530 lines, -81 lines) Patch
M pkg/analysis_server/lib/src/services/completion/arglist_contributor.dart View 7 chunks +177 lines, -20 lines 0 comments Download
M pkg/analysis_server/test/services/completion/arglist_contributor_test.dart View 6 chunks +353 lines, -21 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 1 chunk +0 lines, -40 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 8 months ago (2015-04-09 22:37:51 UTC) #2
scheglov
lgtm
5 years, 8 months ago (2015-04-09 23:49:03 UTC) #3
danrubel
5 years, 8 months ago (2015-04-10 01:23:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 45047 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698