Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1078803002: Fix windows signal test (Closed)

Created:
5 years, 8 months ago by Siggi Cherem (dart-lang)
Modified:
5 years, 8 months ago
Reviewers:
nweiz, kevmoo
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M sdk/lib/_internal/pub/test/run/forwards_signal_windows_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Siggi Cherem (dart-lang)
5 years, 8 months ago (2015-04-09 16:38:19 UTC) #2
kevmoo
Assuming this is playing for consistency w/ the POSIX test... LGTM
5 years, 8 months ago (2015-04-09 17:28:20 UTC) #3
Siggi Cherem (dart-lang)
5 years, 8 months ago (2015-04-09 17:58:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45020 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698