Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1078683002: Be more lean when parsing HTTP headers (Closed)

Created:
5 years, 8 months ago by Søren Gjesse
Modified:
5 years, 8 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Be more lean when parsing HTTP headers Allow only LF instaed of CRLF when parsing headers. Sometimes old or hacked up clients will send the headers like this. R=kustermann@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=44998

Patch Set 1 #

Total comments: 3

Patch Set 2 : Addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -78 lines) Patch
M sdk/lib/io/http_parser.dart View 7 chunks +93 lines, -60 lines 0 comments Download
M tests/standalone/io/http_parser_test.dart View 1 6 chunks +54 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
https://codereview.chromium.org/1078683002/diff/1/sdk/lib/io/http_parser.dart File sdk/lib/io/http_parser.dart (right): https://codereview.chromium.org/1078683002/diff/1/sdk/lib/io/http_parser.dart#newcode340 sdk/lib/io/http_parser.dart:340: bool _headersEnd() { This is a copy of the ...
5 years, 8 months ago (2015-04-09 10:53:29 UTC) #1
kustermann
LGTM https://codereview.chromium.org/1078683002/diff/1/tests/standalone/io/http_parser_test.dart File tests/standalone/io/http_parser_test.dart (right): https://codereview.chromium.org/1078683002/diff/1/tests/standalone/io/http_parser_test.dart#newcode477 tests/standalone/io/http_parser_test.dart:477: _testParseRequest(request, Maybe this one as well?
5 years, 8 months ago (2015-04-09 11:12:33 UTC) #2
Søren Gjesse
https://codereview.chromium.org/1078683002/diff/1/tests/standalone/io/http_parser_test.dart File tests/standalone/io/http_parser_test.dart (right): https://codereview.chromium.org/1078683002/diff/1/tests/standalone/io/http_parser_test.dart#newcode477 tests/standalone/io/http_parser_test.dart:477: _testParseRequest(request, On 2015/04/09 11:12:33, kustermann wrote: > Maybe this ...
5 years, 8 months ago (2015-04-09 11:14:55 UTC) #3
Søren Gjesse
5 years, 8 months ago (2015-04-09 11:15:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 44998 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698