Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1077823002: Adds a simarmv5te build and test target. (Closed)

Created:
5 years, 8 months ago by zra
Modified:
5 years, 8 months ago
Reviewers:
ricow1, regis, siva, Ivan Posva
CC:
reviews_dartlang.org, ricow1, vm-dev_dartlang.org
Visibility:
Public.

Description

Adds a simarmv5te build and test target. Also: - Removes command line flags to choose simulated arm version. I think we should use build targets instead, like in this change, to make building and testing more obvious. - Skips pkg tests on all simulators. R=regis@google.com, ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=45181

Patch Set 1 #

Patch Set 2 : #

Total comments: 8

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -44 lines) Patch
M pkg/pkg.status View 1 2 3 4 2 chunks +1 line, -6 lines 0 comments Download
M runtime/tests/vm/vm.status View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/assembler_arm_test.cc View 1 2 3 4 1 chunk +8 lines, -6 lines 0 comments Download
M runtime/vm/cpu_arm.cc View 1 2 3 4 3 chunks +26 lines, -15 lines 0 comments Download
M runtime/vm/simulator_arm.cc View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/corelib.status View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M tests/lib/lib.status View 1 2 3 4 2 chunks +5 lines, -2 lines 0 comments Download
M tests/standalone/standalone.status View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/pkg_tested/pkg_tested.status View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M tools/build.py View 1 2 3 4 2 chunks +4 lines, -3 lines 0 comments Download
M tools/gyp/configurations.gypi View 1 2 3 4 4 chunks +31 lines, -0 lines 0 comments Download
M tools/gyp/configurations_make.gypi View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M tools/gyp/configurations_msvs.gypi View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M tools/gyp/configurations_xcode.gypi View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M tools/testing/dart/runtime_configuration.dart View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M tools/testing/dart/test_options.dart View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M tools/utils.py View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
zra
5 years, 8 months ago (2015-04-09 20:38:35 UTC) #2
ricow1
python files and status file changes lgtm https://codereview.chromium.org/1077823002/diff/20001/runtime/tests/vm/vm.status File runtime/tests/vm/vm.status (right): https://codereview.chromium.org/1077823002/diff/20001/runtime/tests/vm/vm.status#newcode43 runtime/tests/vm/vm.status:43: [ $arch ...
5 years, 8 months ago (2015-04-10 08:23:41 UTC) #4
zra
https://codereview.chromium.org/1077823002/diff/20001/runtime/tests/vm/vm.status File runtime/tests/vm/vm.status (right): https://codereview.chromium.org/1077823002/diff/20001/runtime/tests/vm/vm.status#newcode43 runtime/tests/vm/vm.status:43: [ $arch == simarm || $arch == simarmv5te || ...
5 years, 8 months ago (2015-04-10 16:07:20 UTC) #5
zra
ping for VM code review.
5 years, 8 months ago (2015-04-15 14:54:16 UTC) #6
zra
5 years, 8 months ago (2015-04-15 19:34:01 UTC) #8
regis
LGTM
5 years, 8 months ago (2015-04-15 20:09:57 UTC) #9
zra
5 years, 8 months ago (2015-04-15 20:45:02 UTC) #10
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as r45181.

Powered by Google App Engine
This is Rietveld 408576698