Add fatal-warnings flag, that turns warnings into compilation errors (the name

Add fatal-warnings flag, that turns warnings into compilation errors (the name
fatal-warnings was choosen to match the flag in dartanalyzer)

BUG= http://dartbug.com/8803
R=johnniwinther@google.com, karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45190

[Siggi Cherem (dart-lang), 2015-04-14 00:39:08]

Patchset #1 (id:1) has been deleted

[Siggi Cherem (dart-lang), 2015-04-14 00:39:38]

sigmund@google.com changed reviewers:
+ johnniwinther@google.com

[karlklose, 2015-04-14 06:16:27]

karlklose@google.com changed reviewers:
+ karlklose@google.com

[karlklose, 2015-04-14 06:16:27]

Change LGTM, but could you add a unit test to tests/compiler/dart2js that tries
to compile something like
  main() { int x = 'hest'; }
and checks that Compiler.compilationFailed == true?

https://codereview.chromium.org/1077373003/diff/20001/pkg/compiler/lib/src/da...
File pkg/compiler/lib/src/dart2js.dart (right):

https://codereview.chromium.org/1077373003/diff/20001/pkg/compiler/lib/src/da...
pkg/compiler/lib/src/dart2js.dart:567: Treat warnings as fatal errors.
Change 'fatal errors' -> 'compilation errors'?

[Johnni Winther, 2015-04-14 07:28:45]

LGTM (I concur with Karl)

[Siggi Cherem (dart-lang), 2015-04-14 21:02:59]

Thanks, good idea. I restructured slightly the test in exit_code_test.dart to
add coverage for this. PTAL

https://codereview.chromium.org/1077373003/diff/20001/pkg/compiler/lib/src/da...
File pkg/compiler/lib/src/dart2js.dart (right):

https://codereview.chromium.org/1077373003/diff/20001/pkg/compiler/lib/src/da...
pkg/compiler/lib/src/dart2js.dart:567: Treat warnings as fatal errors.
On 2015/04/14 06:16:27, karlklose wrote:
> Change 'fatal errors' -> 'compilation errors'?

Done.

[Johnni Winther, 2015-04-15 07:51:28]

lgtm

[Siggi Cherem (dart-lang), 2015-04-15 23:17:31]

Committed patchset #2 (id:40001) manually as 45190 (presubmit successful).