Issue 1077153006: Fix test/runner/signal_test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1077153006: Fix test/runner/signal_test. (Closed)

Created:
5 years, 8 months ago by nweiz

Modified:
5 years, 8 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix test/runner/signal_test. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/1bb4429d45d0991575457eb78fadb15b4c7f72f3

Patch Set 2 : Code review changes #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	test/runner/signal_test.dart	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kevmoo

lgtm https://codereview.chromium.org/1077153006/diff/1/test/runner/signal_test.dart File test/runner/signal_test.dart (right): https://codereview.chromium.org/1077153006/diff/1/test/runner/signal_test.dart#newcode151 test/runner/signal_test.dart:151: return _lines.bind(process.stdout).skip(2).first.then((line) { understanding why it's 2 and ...

5 years, 8 months ago (2015-04-23 00:07:53 UTC) #2

nweiz

https://codereview.chromium.org/1077153006/diff/1/test/runner/signal_test.dart File test/runner/signal_test.dart (right): https://codereview.chromium.org/1077153006/diff/1/test/runner/signal_test.dart#newcode151 test/runner/signal_test.dart:151: return _lines.bind(process.stdout).skip(2).first.then((line) { On 2015/04/23 00:07:53, kevmoo wrote: > ...

5 years, 8 months ago (2015-04-23 00:12:06 UTC) #4

nweiz

5 years, 8 months ago (2015-04-23 00:12:19 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
1bb4429d45d0991575457eb78fadb15b4c7f72f3 (presubmit successful).

Expand Messages | Collapse Messages

Issue 1077153006: Fix test/runner/signal_test. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Code review changes #

Messages