dart2js: Add newline in minified mode.

dart2js: Add newline in minified mode.

R=herhut@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45063

[zarah, 2015-04-10 12:55:14]

zarah@google.com changed reviewers:
+ herhut@google.com

[herhut, 2015-04-10 13:01:57]

lgtm w/ comments

https://codereview.chromium.org/1077123002/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right):

https://codereview.chromium.org/1077123002/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:648: output.add('\n');
How about output.add(N)? That will turn into ";\n" in non-minified and '\n' in
minified mode. The ';' from the js.statement is probably swallowed anyway, no?

[zarah, 2015-04-10 13:05:54]

https://codereview.chromium.org/1077123002/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right):

https://codereview.chromium.org/1077123002/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:648: output.add('\n');
On 2015/04/10 13:01:57, herhut wrote:
> How about output.add(N)? That will turn into ";\n" in non-minified and '\n' in
> minified mode. The ';' from the js.statement is probably swallowed anyway, no?

No, then in minified mode there will be two ';'s. As agreed it stays like this
then.

[zarah, 2015-04-10 13:06:32]

Committed patchset #1 (id:1) manually as 45063 (presubmit successful).

[zarah, 2015-04-10 13:20:24]

https://codereview.chromium.org/1077123002/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart (right):

https://codereview.chromium.org/1077123002/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart:648: output.add('\n');
On 2015/04/10 13:05:54, zarah wrote:
> On 2015/04/10 13:01:57, herhut wrote:
> > How about output.add(N)? That will turn into ";\n" in non-minified and '\n'
in
> > minified mode. The ';' from the js.statement is probably swallowed anyway,
no?
> 
> No, then in minified mode there will be two ';'s. As agreed it stays like this
> then.

sorry, non-minified, just for the record.