Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 1077103002: Handle setter without getter for compounds in SemanticSendVisitor (Closed)

Created:
5 years, 8 months ago by Johnni Winther
Modified:
5 years, 8 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Handle setter without getter for compounds in SemanticSendVisitor + fix status of dart2dart new_backend. BUG= R=asgerf@google.com Committed: https://code.google.com/p/dart/source/detail?r=45065

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -9 lines) Patch
M pkg/compiler/lib/src/resolution/access_semantics.dart View 1 chunk +16 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_resolver.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2dart.status View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test.dart View 3 chunks +13 lines, -2 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 8 months ago (2015-04-10 11:11:33 UTC) #2
asgerf
lgtm
5 years, 8 months ago (2015-04-10 12:53:27 UTC) #3
Johnni Winther
5 years, 8 months ago (2015-04-10 14:01:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45065 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698