Issue 1077093002: Revert "Model 'await for' as an explicit node in tree and fix its handling."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1077093002: Revert "Model 'await for' as an explicit node in tree and fix its handling." (Closed)

Created:
5 years, 8 months ago by herhut

Modified:
5 years, 8 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Revert "Model 'await for' as an explicit node in tree and fix its handling." This reverts revision r45053. BUG= TBR=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=45057

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -169 lines)			Patch
M	pkg/compiler/lib/src/closure.dart	View	1 chunk	+10 lines, -6 lines	0 comments	Download
M	pkg/compiler/lib/src/compiler.dart	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	pkg/compiler/lib/src/dart_backend/backend_ast_to_frontend_ast.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/inferrer/inferrer_visitor.dart	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart	View	2 chunks	+12 lines, -37 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/backend.dart	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	pkg/compiler/lib/src/resolution/members.dart	View	3 chunks	+4 lines, -23 lines	0 comments	Download
M	pkg/compiler/lib/src/resolution/registry.dart	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	pkg/compiler/lib/src/scanner/listener.dart	View	1 chunk	+2 lines, -7 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/builder.dart	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/nodes.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/tree/nodes.dart	View	6 chunks	+9 lines, -36 lines	0 comments	Download
M	pkg/compiler/lib/src/tree/prettyprint.dart	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	pkg/compiler/lib/src/tree/unparser.dart	View	1 chunk	+5 lines, -17 lines	0 comments	Download
M	pkg/compiler/lib/src/typechecker.dart	View	1 chunk	+1 line, -7 lines	0 comments	Download
M	pkg/compiler/lib/src/use_unused_api.dart	View	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

herhut

Committed patchset #1 (id:1) manually as 45057 (presubmit successful).

5 years, 8 months ago (2015-04-10 09:35:58 UTC) #2

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages