Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1076873003: Update analyzer readme (Closed)

Created:
5 years, 8 months ago by Brian Wilkerson
Modified:
5 years, 8 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address comments #

Total comments: 4

Patch Set 3 : Addressed more comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -18 lines) Patch
M pkg/analyzer/README.md View 1 2 1 chunk +25 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Brian Wilkerson
5 years, 8 months ago (2015-04-09 16:32:18 UTC) #2
sethladd
https://codereview.chromium.org/1076873003/diff/1/pkg/analyzer/README.md File pkg/analyzer/README.md (right): https://codereview.chromium.org/1076873003/diff/1/pkg/analyzer/README.md#newcode6 pkg/analyzer/README.md:6: an editor or IDE, you should use the analysis ...
5 years, 8 months ago (2015-04-09 16:37:42 UTC) #3
scheglov
https://codereview.chromium.org/1076873003/diff/1/pkg/analyzer/README.md File pkg/analyzer/README.md (right): https://codereview.chromium.org/1076873003/diff/1/pkg/analyzer/README.md#newcode7 pkg/analyzer/README.md:7: The analysis server is currently shipping as an executable ...
5 years, 8 months ago (2015-04-09 18:18:29 UTC) #5
Paul Berry
lgtm
5 years, 8 months ago (2015-04-09 18:46:08 UTC) #6
Brian Wilkerson
PTAL https://codereview.chromium.org/1076873003/diff/1/pkg/analyzer/README.md File pkg/analyzer/README.md (right): https://codereview.chromium.org/1076873003/diff/1/pkg/analyzer/README.md#newcode6 pkg/analyzer/README.md:6: an editor or IDE, you should use the ...
5 years, 8 months ago (2015-04-09 19:11:52 UTC) #7
sethladd
https://codereview.chromium.org/1076873003/diff/20001/pkg/analyzer/README.md File pkg/analyzer/README.md (right): https://codereview.chromium.org/1076873003/diff/20001/pkg/analyzer/README.md#newcode6 pkg/analyzer/README.md:6: an editor or IDE, you should use the analysis ...
5 years, 8 months ago (2015-04-09 20:19:13 UTC) #8
Brian Wilkerson
PTAL https://codereview.chromium.org/1076873003/diff/20001/pkg/analyzer/README.md File pkg/analyzer/README.md (right): https://codereview.chromium.org/1076873003/diff/20001/pkg/analyzer/README.md#newcode6 pkg/analyzer/README.md:6: an editor or IDE, you should use the ...
5 years, 8 months ago (2015-04-10 17:18:26 UTC) #9
sethladd
lgtm thanks for the improvements!
5 years, 8 months ago (2015-04-10 17:19:31 UTC) #10
Brian Wilkerson
5 years, 8 months ago (2015-04-10 17:21:36 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 45074 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698