Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1433)

Issue 1076803003: Change the URL-space exposed by the browser server. (Closed)

Created:
5 years, 8 months ago by nweiz
Modified:
5 years, 8 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change the URL-space exposed by the browser server. This is a step towards Dartium support. Rather than only serving the compiled JS and the HTML necessary to run it, the entire package is now served with the compiled JS and HTML wrappers overlayed on top. This will allow Dartium to load all necessary sources from the server, and incidentally also allows tests to access assets. See #60 Closes #27 R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/d2828edbef5ca921b60a363888f953661262eaf2

Patch Set 1 #

Patch Set 2 : Changelog + pubspec #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+343 lines, -74 lines) Patch
M CHANGELOG.md View 1 1 chunk +5 lines, -0 lines 0 comments Download
M lib/pub_serve.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M lib/src/runner/browser/server.dart View 9 chunks +105 lines, -46 lines 0 comments Download
M lib/src/runner/loader.dart View 5 chunks +10 lines, -3 lines 0 comments Download
M lib/src/util/one_off_handler.dart View 2 chunks +7 lines, -11 lines 0 comments Download
A lib/src/util/path_handler.dart View 1 chunk +58 lines, -0 lines 0 comments Download
M lib/src/utils.dart View 2 chunks +63 lines, -0 lines 0 comments Download
M pubspec.yaml View 1 2 chunks +2 lines, -1 line 0 comments Download
M test/runner/browser/loader_test.dart View 3 chunks +4 lines, -2 lines 0 comments Download
M test/runner/loader_test.dart View 2 chunks +3 lines, -2 lines 1 comment Download
M test/runner/pub_serve_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
A test/util/path_handler_test.dart View 1 chunk +77 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
5 years, 8 months ago (2015-04-11 00:19:00 UTC) #1
kevmoo
LGTM Have you sniff tested support for Shelf 0.5.x? https://codereview.chromium.org/1076803003/diff/20001/test/runner/loader_test.dart File test/runner/loader_test.dart (right): https://codereview.chromium.org/1076803003/diff/20001/test/runner/loader_test.dart#newcode90 test/runner/loader_test.dart:90: ...
5 years, 8 months ago (2015-04-11 01:22:25 UTC) #2
kevmoo
On 2015/04/11 01:22:25, kevmoo wrote: > LGTM > > Have you sniff tested support for ...
5 years, 8 months ago (2015-04-11 01:23:21 UTC) #3
kevmoo
On 2015/04/11 01:23:21, kevmoo wrote: > On 2015/04/11 01:22:25, kevmoo wrote: > > LGTM > ...
5 years, 8 months ago (2015-04-13 19:25:53 UTC) #4
nweiz
5 years, 8 months ago (2015-04-13 19:26:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d2828edbef5ca921b60a363888f953661262eaf2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698