Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 1076793005: Fine-grain field, getter, setter, and function access in IrBuilder. (Closed)

Created:
5 years, 8 months ago by Johnni Winther
Modified:
5 years, 8 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Fine-grain field, getter, setter, and function access in IrBuilder. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=45055

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+377 lines, -179 lines) Patch
M pkg/analyzer2dart/lib/src/cps_generator.dart View 6 chunks +19 lines, -11 lines 0 comments Download
M pkg/analyzer2dart/lib/src/modely.dart View 2 chunks +6 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 14 chunks +255 lines, -89 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 46 chunks +91 lines, -75 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 8 months ago (2015-04-09 14:30:43 UTC) #2
karlklose
LGTM.
5 years, 8 months ago (2015-04-10 07:30:44 UTC) #3
Johnni Winther
5 years, 8 months ago (2015-04-10 08:41:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45055 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698