Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1076183002: Fix names of some tests in dart2js_extra. (Closed)

Created:
5 years, 8 months ago by herhut
Modified:
5 years, 8 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, floitsch
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Fix names of some tests in dart2js_extra. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=45231

Patch Set 1 #

Patch Set 2 : Deleted test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-3 lines, -73 lines) Patch
D tests/compiler/dart2js_extra/22776.dart View 1 chunk +0 lines, -23 lines 0 comments Download
A + tests/compiler/dart2js_extra/22776_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D tests/compiler/dart2js_extra/22895.dart View 1 chunk +0 lines, -11 lines 0 comments Download
A + tests/compiler/dart2js_extra/22895_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D tests/compiler/dart2js_extra/if_in_loop.dart View 1 chunk +0 lines, -26 lines 0 comments Download
A + tests/compiler/dart2js_extra/if_in_loop_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D tests/compiler/dart2js_extra/runtime_type_isolate.dart View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
herhut
Some tests in dart2js_extra were never run due to their name. I renamed those but ...
5 years, 8 months ago (2015-04-10 11:42:00 UTC) #2
karlklose
On 2015/04/10 11:42:00, herhut wrote: > Some tests in dart2js_extra were never run due to ...
5 years, 8 months ago (2015-04-10 12:10:03 UTC) #3
karlklose
LGTM.
5 years, 8 months ago (2015-04-10 12:10:30 UTC) #4
herhut
5 years, 8 months ago (2015-04-17 09:54:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 45231 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698