Make all of stdout/stderr/stdin pipes close-on-exec when spawing child processes.

Make all of stdout/stderr/stdin pipes close-on-exec when spawing child processes.

BUG=
R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45370

[Anders Johnsen, 2015-04-22 19:45:31]

ajohnsen@google.com changed reviewers:
+ iposva@google.com, sgjesse@google.com

[kevmoo, 2015-04-22 19:46:40]

On 2015/04/22 19:45:31, Anders Johnsen wrote:

Why is this good? Does this introduce a behavior change?

...just curious. :-)

[kustermann, 2015-04-23 01:54:16]

kustermann@google.com changed reviewers:
+ kustermann@google.com

[kustermann, 2015-04-23 01:54:16]

DBC: We're all aware of the race. So pipe2() was introduced in 2008, more
precisely 2.6.27. So it's a question whether we want dart on linux systems with
a pre 2.6.27 kernel or not. Do we know what our embedded users are using?

[Søren Gjesse, 2015-04-23 06:58:51]

I was about to ask about the use of pipe2, but as it is already used we should
be fine.

https://codereview.chromium.org/1076093004/diff/1/runtime/bin/process_linux.cc
File runtime/bin/process_linux.cc (left):

https://codereview.chromium.org/1076093004/diff/1/runtime/bin/process_linux.c...
runtime/bin/process_linux.cc:379: int CreatePipes() {
Can't we then get rid of the explicit closing in the first four lines of
ProcessStarter::ExecProcess?

[Anders Johnsen, 2015-04-23 07:05:34]

PTAL

https://codereview.chromium.org/1076093004/diff/1/runtime/bin/process_linux.cc
File runtime/bin/process_linux.cc (left):

https://codereview.chromium.org/1076093004/diff/1/runtime/bin/process_linux.c...
runtime/bin/process_linux.cc:379: int CreatePipes() {
On 2015/04/23 06:58:51, Søren Gjesse wrote:
> Can't we then get rid of the explicit closing in the first four lines of
> ProcessStarter::ExecProcess?

You are right, it should be safe to remove those.

[Anders Johnsen, 2015-04-23 07:07:04]

PTAL

[Søren Gjesse, 2015-04-23 07:31:37]

lgtm

[Anders Johnsen, 2015-04-23 07:38:01]

Committed patchset #2 (id:20001) manually as 45370 (presubmit successful).