Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 1075923002: Refactor the try statement analysis results. (Closed)

Created:
5 years, 8 months ago by Kevin Millikin (Google)
Modified:
5 years, 8 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Refactor the try statement analysis results. In the dart2js CPS backend, move the frontend-specific try statement analysis results out of the frontend-independent IrBuilder and into the frontend-specific IrBuilderVisitor. BUG= R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=45009

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -53 lines) Patch
M pkg/analyzer2dart/lib/src/cps_generator.dart View 4 chunks +6 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 7 chunks +6 lines, -32 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 7 chunks +43 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Kevin Millikin (Google)
5 years, 8 months ago (2015-04-09 14:11:35 UTC) #2
Johnni Winther
LGTM
5 years, 8 months ago (2015-04-09 14:16:37 UTC) #3
Kevin Millikin (Google)
5 years, 8 months ago (2015-04-09 14:17:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45009 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698