Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1075493003: Remove zapping of registers that has not turned up any GC bugs in a long time. (Closed)

Created:
5 years, 8 months ago by regis
Modified:
5 years, 8 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Remove zapping of registers introduced in r37297 that has not turned up any GC bugs in a long time. R=rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=44982

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -93 lines) Patch
M runtime/vm/flow_graph_compiler_arm.cc View 3 chunks +0 lines, -14 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 3 chunks +0 lines, -14 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 3 chunks +0 lines, -14 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 3 chunks +0 lines, -14 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 3 chunks +0 lines, -14 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/raw_object.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
regis
5 years, 8 months ago (2015-04-08 20:11:32 UTC) #2
rmacnak
lgtm Can you reference r37297 in the commit message?
5 years, 8 months ago (2015-04-08 20:18:42 UTC) #3
regis
On 2015/04/08 20:18:42, rmacnak wrote: > lgtm > > Can you reference r37297 in the ...
5 years, 8 months ago (2015-04-08 20:38:13 UTC) #4
regis
5 years, 8 months ago (2015-04-08 20:56:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r44982 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698