Add tests for evalutating against activation records.

Add tests for evalutating against activation records.

Report an exception when the testee hits an assertion failure.

BUG=http://dartbug.com/20047
R=johnmccutchan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45263

[rmacnak, 2015-04-10 20:53:11]

rmacnak@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2015-04-10 21:15:25]

https://codereview.chromium.org/1075423002/diff/1/runtime/observatory/tests/s...
File runtime/observatory/tests/service/evaluate_activation_test.dart (right):

https://codereview.chromium.org/1075423002/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/evaluate_activation_test.dart:71: var n = 1;
frameNum ?

https://codereview.chromium.org/1075423002/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/evaluate_activation_test.dart:72:
expect((await isolate.evalFrame(n, '123')).valueAsString,          ///
brokeninstance: runtime error
column limits..

https://codereview.chromium.org/1075423002/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/evaluate_activation_test.dart:189:
sub.cancel();  // So the next test gets the events.
these tests should return a completer's future that is completed after resuming
the isolate (e.g. line 182).

[rmacnak, 2015-04-10 22:36:44]

https://codereview.chromium.org/1075423002/diff/1/runtime/observatory/tests/s...
File runtime/observatory/tests/service/evaluate_activation_test.dart (right):

https://codereview.chromium.org/1075423002/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/evaluate_activation_test.dart:71: var n = 1;
On 2015/04/10 21:15:25, Cutch wrote:
> frameNum ?

Done.

https://codereview.chromium.org/1075423002/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/evaluate_activation_test.dart:72:
expect((await isolate.evalFrame(n, '123')).valueAsString,          ///
brokeninstance: runtime error
On 2015/04/10 21:15:25, Cutch wrote:
> column limits..

Lots of reshuffling, still doesn't quite fit with multitest.

https://codereview.chromium.org/1075423002/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/evaluate_activation_test.dart:189:
sub.cancel();  // So the next test gets the events.
On 2015/04/10 21:15:25, Cutch wrote:
> these tests should return a completer's future that is completed after
resuming
> the isolate (e.g. line 182).

That's too soon because the result of the library eval is still in flight. Moved
the cancellation to before the resume, so there is always at most one event
subscription in flight and it is always cancelled before its test completes (and
so won't resume another test's breakpoint).

https://codereview.chromium.org/1075423002/diff/40001/runtime/observatory/tes...
File runtime/observatory/tests/service/test_helper.dart (right):

https://codereview.chromium.org/1075423002/diff/40001/runtime/observatory/tes...
runtime/observatory/tests/service/test_helper.dart:72: final killed = -15;
This might be different on Windows...

[rmacnak, 2015-04-16 20:47:35]

https://codereview.chromium.org/1075423002/diff/40001/runtime/observatory/tes...
File runtime/observatory/tests/service/test_helper.dart (right):

https://codereview.chromium.org/1075423002/diff/40001/runtime/observatory/tes...
runtime/observatory/tests/service/test_helper.dart:72: final killed = -15;
On 2015/04/10 22:36:44, rmacnak wrote:
> This might be different on Windows...

Of course we can keep track of whether we killed the testee. Do that instead.

[Cutch, 2015-04-17 21:11:11]

lgtm

[rmacnak, 2015-04-18 00:06:28]

Committed patchset #5 (id:80001) manually as 45263 (presubmit successful).