Issue 1075113003: Pull JS assignments into var initializer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1075113003: Pull JS assignments into var initializer. (Closed)

Created:
5 years, 8 months ago by asgerf

Modified:
5 years, 8 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

Pull JS assignments into var initializer. E.g. var x; x = new Foo(); x.bar(); return x; Becomes: var x = new Foo(); x.bar(); return x; BUG= R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=45058

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -44 lines)			Patch
M	pkg/compiler/lib/src/js_backend/codegen/codegen.dart	View		2 chunks	+35 lines, -5 lines	0 comments	Download
M	tests/compiler/dart2js/js_backend_cps_ir_basic_test.dart	View	1	3 chunks	+3 lines, -8 lines	0 comments	Download
M	tests/compiler/dart2js/js_backend_cps_ir_closures_test.dart	View	1	4 chunks	+4 lines, -9 lines	0 comments	Download
M	tests/compiler/dart2js/js_backend_cps_ir_constructor_test.dart	View	1	5 chunks	+5 lines, -14 lines	0 comments	Download
M	tests/compiler/dart2js/js_backend_cps_ir_control_flow_test.dart	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	tests/compiler/dart2js/js_backend_cps_ir_interceptors_test.dart	View	1	2 chunks	+2 lines, -4 lines	0 comments	Download
M	tests/compiler/dart2js/js_backend_cps_ir_supercall_test.dart	View	1	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

asgerf

5 years, 8 months ago (2015-04-10 09:42:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 45058 (presubmit successful).